-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add precise image warping to Mosaic plugin #1004
base: main
Are you sure you want to change the base?
Conversation
5cde698
to
ed73447
Compare
Left todo: tile labelling |
labeling fixed |
e9eef93
to
2a6239b
Compare
@pllim, it should be in good enough shape for you to test now. I think your org has a plugin that is a subclass of this, right? Probably there are some more things to fix or work out for backward compatibility. For example, it now creates an alpha mask in the mosaic image so that the empty space between the tiles does not show. But we might need to strip it off for saving the result mosaic? Let me know how it breaks things for you! 😸 |
2a6239b
to
fc1d24a
Compare
Rebased |
Thanks, I'll put this in my queue to review. 😸 |
Take your time. I propose to bump this forward for release 4.0 in the fall. |
fc1d24a
to
a8e68da
Compare
@ejeschke , sorry this slipped through. Are you still waiting for my review? Would you mind rebasing? Thanks! |
a8e68da
to
c3ad173
Compare
Rebased. No hurry on this one, @pllim! |
This should still be considered a draft PR. |
I checked out this branch, using dev version of https://wss-tools.readthedocs.io/en/latest/wss_tools/quip/mosaicauto.html I get this error:
There is no error with the same images using dev version of Ginga instead of this branch. |
Kicked down the road to release 4.1 |
c3ad173
to
84bb5a0
Compare
84bb5a0
to
d16cd5f
Compare
- This adds an option to the Mosaic plugin to warp images precisely according to the WCS of the reference image. This option is slower than the standard rotate/flip mosaicing, but can produce more accurate mosaics, especially when there is some distortion near the edge of the field - The same functionality was previously added to the Collage plugin
d16cd5f
to
c5fdb8f
Compare
Rebased |
This adds an option to the Mosaic plugin to warp images precisely according to the WCS of the reference image. This option is slower than the standard rotate/flip mosaicing, but can produce more accurate mosaics, especially when there is some distortion near the edge of the field.
The same functionality was previously added to the Collage plugin.