Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain the need having three validateTargetLocationsXX methods #798

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Explain the need having three validateTargetLocationsXX methods #798

wants to merge 7 commits into from

Commits on Jun 27, 2024

  1. improve comments and readability

    @AndrewShf @Ao-senXiong
    AndrewShf authored and Ao-senXiong committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    632493f View commit details
    Browse the repository at this point in the history

  2. improve comments and readability

    @AndrewShf @Ao-senXiong
    AndrewShf authored and Ao-senXiong committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    cc14e53 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Werner Dietl <[email protected]>
    @AndrewShf @wmdietl @Ao-senXiong
    2 people authored and Ao-senXiong committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    58b3f05 View commit details
    Browse the repository at this point in the history

  4. clarify the implementation details of having three validating methods

    @AndrewShf @Ao-senXiong
    AndrewShf authored and Ao-senXiong committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    633f95e View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Merge branch 'master' into haifeng-targetlocation

    @Ao-senXiong
    Ao-senXiong authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    14e18e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Merge branch 'master' into haifeng-targetlocation

    @Ao-senXiong
    Ao-senXiong authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ac3361b View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Merge branch 'master' into haifeng-targetlocation

    @Ao-senXiong
    Ao-senXiong authored Sep 8, 2024
    Configuration menu
    Copy the full SHA
    16e180e View commit details
    Browse the repository at this point in the history