Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't erase the type argument of receiver #793

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Ao-senXiong
Copy link
Member

for this code

public class Test<T> {
   Test <T> a;

    Test() {
        a = new Test<>();
        foo();
    }

    void foo() {}
}

error message before the change:

Test.java:6: error: [method.invocation.invalid] call to foo() not allowed on the given receiver.
        foo();
           ^
  found   : @UnderInitialization(Test.class) Test</*RAW*/>
  required: @Initialized Test</*RAW*/>

error message after the change:

Test.java:6: error: [method.invocation.invalid] call to foo() not allowed on the given receiver.
        foo();
           ^
  found   : @UnderInitialization(Test.class) Test<T extends @Initialized Object>
  required: @Initialized Test<T extends @Initialized Object>
1 error

Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, please add a jtreg test.

@wmdietl wmdietl assigned Ao-senXiong and unassigned wmdietl Jun 26, 2024
@wmdietl
Copy link
Member

wmdietl commented Jun 26, 2024

Maybe this would fix #104? Can you try with tests from that issue?

@Ao-senXiong
Copy link
Member Author

Maybe this would fix #104? Can you try with tests from that issue?

Just checked, this did not fix it.

@Ao-senXiong Ao-senXiong requested a review from wmdietl June 27, 2024 04:08
@Ao-senXiong Ao-senXiong assigned wmdietl and unassigned Ao-senXiong Jun 27, 2024
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting to look into this. We should look at this properly and fix #104 while we touch this code.

@@ -3772,7 +3772,7 @@ protected void checkMethodInvocability(
return;
}

AnnotatedTypeMirror methodReceiver = method.getReceiverType().getErased();
AnnotatedTypeMirror methodReceiver = method.getReceiverType();
AnnotatedTypeMirror treeReceiver = methodReceiver.shallowCopy(false);
AnnotatedTypeMirror rcv = atypeFactory.getReceiverType(tree);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subtype test below is typeHierarchy.isSubtype(treeReceiver, methodReceiver);
treeReceiver is a shallow copy of methodReceiver, with just the main modifier copied from the actual receiver rcv of the method invocation.
So to fix #104 we should really understand better what this code is supposed to do.
What goes from if we use typeHierarchy.isSubtype(rcv, methodReceiver);? Why this strange copying of annotations?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look into #104 after this PR.

*
* @compile/fail/ref=TypeArgument.out -XDrawDiagnostics -processor org.checkerframework.checker.nullness.NullnessChecker TypeArgument.java
*/
public class TypeArgument<T> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeArgument is not a very descriptive name for this test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to NonRawTypeArgumentTest

checker/jtreg/nullness/type-argument/TypeArgument.out Outdated Show resolved Hide resolved
@wmdietl wmdietl assigned Ao-senXiong and unassigned wmdietl Jun 27, 2024
@Ao-senXiong Ao-senXiong requested a review from wmdietl June 27, 2024 18:57
@Ao-senXiong Ao-senXiong assigned wmdietl and unassigned Ao-senXiong Jun 27, 2024
@@ -0,0 +1,14 @@
/*
* @test
* @summary Test case for type argument in method invocation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this summary confusing and don't see how this matches the code - there is no type argument there.
You need to say something about what type argument you mean.
Same with the test name 'NonRawTypeArgument` isn't very helpful - all type arguments are non-raw, otherwise there wouldn't be type arguments...

@wmdietl wmdietl assigned Ao-senXiong and unassigned wmdietl Jun 28, 2024
@Ao-senXiong Ao-senXiong requested a review from wmdietl July 3, 2024 18:36
@Ao-senXiong Ao-senXiong removed their assignment Jul 3, 2024
@Ao-senXiong
Copy link
Member Author

This is a partial fix, look into the error message in subclass and #104

@Ao-senXiong
Copy link
Member Author

#104 seems like really different issue after I debugging the code. Maybe we should merge this independently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants