Feature/sms templates #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikusteu
force-pushed
the
feature/sms-templates
branch
from
d138f9d
to
377aace
Compare
* reorganise the code in more self contained, modular (and simplified) chunks * update the UI for more comprehensive UX * update template interpolation logic to automtically add `</br>` after newlines (so that we don't have to use html `<p>` tags) * remove `<p>` tags from default email templates
…able for SMS as well: * Refactor `EmailType` and `EmailTypePayload` types to `ClientMessageType` and `ClientMessagePayload` respectively (and include `ClientMessageMethod`) * Flatten `client` in the client message payload (ex email payload) for easier type composablity
* Update send SMS https endpoint to use templates when constructing an SMS message for delivery * Remove unnecessary `SendBookingsLinkMethod` enumn (replaced by ` ClientMessageMethod`)
* Create a SMS Templates tab * Refactor TemplateBlock for more composability * Update translations
…component wrapping the contents in `div`) * Apply the update to admin_preferences page
ikusteu
force-pushed
the
feature/sms-templates
branch
from
377aace
to
f1300d9
Compare
* Memoize the `Component` wrapper in `LayoutContent` (to prevent rerendering each time props update) * Update `customers.json` in e2e package to all have a valid phone number (no idea why that wasn't caught earlier)
silviot
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
I was unable to go through the code. I tried the functionality, and I really like how it looks now. I think it would make sense to not include OrganizationName in the template variables (admins will find hard coding the string easier IMO) but there's no need to make changes to this PR. Merging!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #700