Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loading spinner to submit button on self reg #791

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Add loading spinner to submit button on self reg #791

merged 2 commits into from
Sep 4, 2023

Conversation

fadwamahmoud
Copy link
Collaborator

Fixes #787

@fadwamahmoud fadwamahmoud self-assigned this Jul 12, 2023
ikusteu
ikusteu approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@ikusteu ikusteu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A click through test works. Left some minor suggestions.

@silviot silviot merged commit da5eb86 into master Sep 4, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silviot silviot silviot approved these changes

@ikusteu ikusteu ikusteu approved these changes

Assignees

@fadwamahmoud fadwamahmoud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve /self_register usability - sumbission indication: 1pts
3 participants
@fadwamahmoud @silviot @ikusteu