Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filtering support type uint64 #255

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

srstack
Copy link

@srstack srstack commented Oct 10, 2023

No description provided.

@srstack srstack requested a review from a team as a code owner October 10, 2023 10:07
@srstack
Copy link
Author

srstack commented Oct 17, 2023

@alethenorio @odsod PTAL ~

@srstack srstack changed the title filtering: support type uint64 feat: filtering support type uint64 Oct 31, 2023
@srstack
Copy link
Author

srstack commented Oct 31, 2023

@alethenorio @odsod PTAL ~

@alethenorio PTAL ?

filtering/parser.go Outdated Show resolved Hide resolved
filtering/parser.go Outdated Show resolved Hide resolved
filtering/checker.go Outdated Show resolved Hide resolved
@srstack srstack requested a review from odsod December 1, 2023 13:35
@@ -215,6 +222,10 @@ func (c *Checker) checkInt64Literal(e *expr.Expr) error {
return c.setType(e, TypeInt)
}

func (c *Checker) checkUint64Literal(e *expr.Expr) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't alias Uint to Uint64 - let's use consistent terminology across the board

Copy link
Author

@srstack srstack Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aip-go/filtering/checker.go

Lines 214 to 216 in 0041801

func (c *Checker) checkInt64Literal(e *expr.Expr) error {
return c.setType(e, TypeInt)
}

I was referenced here, also alias Int to Int64, ,need modifications too? @odsod

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odsod PTAL ~

@srstack srstack requested a review from odsod December 14, 2023 16:33
@nmittler
Copy link

@odsod @srstack this would be useful .... is it possible to get this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants