polishing

types/src/extended_header.rs

@@ -6,7 +6,6 @@ use std::fmt::{Display, Formatter};
 use std::time::Duration;
 
 use celestia_proto::header::pb::ExtendedHeader as RawExtendedHeader;
-use serde::de::Error as _;
 use serde::{Deserialize, Deserializer, Serialize, Serializer};
 use tendermint::block::header::Header;
 use tendermint::block::{Commit, Height};
@@ -163,16 +162,12 @@ impl ExtendedHeader {
             )
         }
 
-        let Some(data_hash) = self.header.data_hash else {
-            bail_validation!("header dah hash is missing")
-        };
-
         // ensure data root from raw header matches computed root
-        if self.dah.hash() != data_hash {
+        if self.dah.hash() != self.header.data_hash.unwrap_or_default() {
             bail_validation!(
                 "dah hash ({}) != header dah hash ({})",
                 self.dah.hash(),
-                data_hash,
+                self.header.data_hash.unwrap_or_default(),
             )
         }
 
@@ -519,7 +514,7 @@ impl<'de> Deserialize<'de> for ExtendedHeader {
     {
         let custom_de = custom_serde::SerdeExtendedHeader::deserialize(deserializer)?;
         let pb: RawExtendedHeader = custom_de.into();
-        ExtendedHeader::try_from(pb).map_err(|e| D::Error::custom(e.to_string()))
+        ExtendedHeader::try_from(pb).map_err(serde::de::Error::custom)
     }
 }
 

types/src/lib.rs

@@ -31,9 +31,6 @@ mod tx_config;
 mod validate;
 mod validator_set;
 
-pub use tendermint;
-pub use tendermint_proto;
-
 pub use crate::blob::{Blob, Commitment};
 pub use crate::block::*;
 pub use crate::consts::appconsts::AppVersion;

types/src/serializers/hash.rs

@@ -2,7 +2,6 @@
 
 use std::str::FromStr;
 
-use serde::de::Error as _;
 use serde::{Deserialize, Deserializer, Serialize, Serializer};
 use tendermint::hash::Hash;
 
@@ -12,7 +11,7 @@ where
     D: Deserializer<'de>,
 {
     let hex = Option::<String>::deserialize(deserializer)?.unwrap_or_default();
-    Hash::from_str(&hex).map_err(|e| D::Error::custom(e.to_string()))
+    Hash::from_str(&hex).map_err(serde::de::Error::custom)
 }
 
 /// Serialize [`tendermint::hash::Hash`].