Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TrackClusterMergeSplitter to output track-cluster associations (PFA0) #1699

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ruse-traveler
Copy link
Contributor

@ruse-traveler ruse-traveler commented Jan 9, 2025

Briefly, what does this PR introduce?

This PR updates the TrackClusterMergeSplitter algorithm to output edm4eic::TrackClusterMatch associations. In this process, it reaps what was sown by originally writing the algorithm to operate on protoclusters rather than clusters...

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

Yes. Track-cluster associations will now be produced by the algorithm.

To-Do

  • Integrate cluster (re-)reconstruction into splitting
  • Output track-cluster matches
  • Add cluster shape calculation
  • Handle associations
  • Figure out bug with EDM4EIC version checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant