Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some data types #1473

Merged
merged 3 commits into from
May 31, 2024
Merged

Fix some data types #1473

merged 3 commits into from
May 31, 2024

Conversation

simonge
Copy link
Contributor

@simonge simonge commented May 29, 2024

Briefly, what does this PR introduce?

Fixes Error: /home/runner/work/EICrecon/EICrecon/src/algorithms/fardetectors/FarDetectorTrackerCluster.cc:89:20: runtime error: implicit conversion from type 'std::uint64_t' (aka 'unsigned long') of value 18248302638875542214 (64-bit, unsigned) to type 'const long' changed the value to -198441434834009402 (64-bit, signed)

Flagged by ASAN in the CI runs, item in issue #1476

@github-actions github-actions bot added the topic: tracking Relates to tracking reconstruction label May 29, 2024
@simonge simonge requested a review from veprbl May 30, 2024 20:43
@veprbl veprbl added this to the 24.06.0 milestone May 30, 2024
@simonge simonge added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit cd5e3c7 May 31, 2024
89 of 91 checks passed
@simonge simonge deleted the fix_data_types branch May 31, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: tracking Relates to tracking reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants