Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated auditdetails logic #974

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

updated auditdetails logic #974

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea71284
updated auditdetails logic
Taniya-eGov Oct 10, 2024
6a495cb
fetch auditdetails from db
Taniya-eGov Oct 11, 2024
18ddb96
updated code
Taniya-eGov Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...ervices/ws-services/src/main/java/org/egov/waterconnection/service/EnrichmentService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,13 @@ private List<String> getIdList(RequestInfo requestInfo, String tenantId, String
* @param waterConnectionRequest WaterConnectionRequest Object
*/
public void enrichUpdateWaterConnection(WaterConnectionRequest waterConnectionRequest) {
AuditDetails currentAuditDetails = waterConnectionRequest.getWaterConnection().getAuditDetails();
AuditDetails auditDetails = waterServicesUtil
.getAuditDetails(waterConnectionRequest.getRequestInfo().getUserInfo().getUuid(), false);

auditDetails.setCreatedBy(currentAuditDetails.getCreatedBy());
auditDetails.setCreatedTime(currentAuditDetails.getCreatedTime());

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Potential NullPointerException when accessing currentAuditDetails

Accessing currentAuditDetails.getCreatedBy() and currentAuditDetails.getCreatedTime() without checking if currentAuditDetails is null may lead to a NullPointerException. Consider adding a null check before accessing these methods.

Apply this diff to add a null check:

+        if (currentAuditDetails != null) {
           auditDetails.setCreatedBy(currentAuditDetails.getCreatedBy());
           auditDetails.setCreatedTime(currentAuditDetails.getCreatedTime());
+        }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
AuditDetails currentAuditDetails = waterConnectionRequest.getWaterConnection().getAuditDetails();
AuditDetails auditDetails = waterServicesUtil
.getAuditDetails(waterConnectionRequest.getRequestInfo().getUserInfo().getUuid(), false);
auditDetails.setCreatedBy(currentAuditDetails.getCreatedBy());
auditDetails.setCreatedTime(currentAuditDetails.getCreatedTime());
AuditDetails currentAuditDetails = waterConnectionRequest.getWaterConnection().getAuditDetails();
AuditDetails auditDetails = waterServicesUtil
.getAuditDetails(waterConnectionRequest.getRequestInfo().getUserInfo().getUuid(), false);
if (currentAuditDetails != null) {
auditDetails.setCreatedBy(currentAuditDetails.getCreatedBy());
auditDetails.setCreatedTime(currentAuditDetails.getCreatedTime());
}

waterConnectionRequest.getWaterConnection().setAuditDetails(auditDetails);
WaterConnection connection = waterConnectionRequest.getWaterConnection();
if (!CollectionUtils.isEmpty(connection.getDocuments())) {
Expand Down