mdms integration fixes

[nabeelmd-eGov]

No description provided.

[coderabbitai]

Walkthrough

Walkthrough

The updates involve migrating various configurations related to the campaign manager module from local files to a more dynamic and configurable Master Data Management System (MDMS). Changes include fetching configurations like product types, delivery settings, and operator settings dynamically using custom hooks, and updating components to utilize these new data fetching methods.

Changes

File Path	Change Summary
.../campaign-manager/src/components/AddProductField.js	Added custom hook for fetching productType, using tenantId.
.../campaign-manager/src/configs/*.js	Migrated attribute, delivery, operator, and productType configs to MDMS.
.../campaign-manager/src/pages/employee/AddProduct.js	Updated import source for Toast.
.../campaign-manager/src/pages/employee/deliveryRule/*	Updated components to use dynamically loaded configs from MDMS.

Possibly related issues

• Redesign and rewrite of MDMS Digit-Core#76: The PR's focus on enhancing the use of MDMS for campaign management aligns with the issue's objective to make master data management more configurable and user-friendly.

🐇💻✨
A hop here, a code tweak there,
Configs fly through digital air.
From static files, we now refrain,
In MDMS, our data shall remain.
Celebrate the change, for it's quite grand,
In the land of code, where we stand.
🌟🐰

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 10e3596 and a36dbac.

Files selected for processing (8)

• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/AddProductField.js (1 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/configs/attributeConfig.js (1 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/configs/deliveryConfig.js (1 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/configs/operatorConfig.js (1 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/configs/productType.js (1 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/AddProduct.js (1 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/deliveryRule/AddDeliverycontext.js (7 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/deliveryRule/index.js (4 hunks)

Files skipped from review due to trivial changes (2)

• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/configs/operatorConfig.js
• micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/configs/productType.js

Additional Context Used

Path-based Instructions (6)

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/configs/attributeConfig.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/configs/deliveryConfig.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/AddProductField.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/AddProduct.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/deliveryRule/index.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/deliveryRule/AddDeliverycontext.js (1)

Pattern **/*.js: check

Additional comments not posted (9)

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/configs/attributeConfig.js (1)

1-1: Migration to MDMS noted. Ensure that all references to attributeConfig are updated to fetch from MDMS dynamically.

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/configs/deliveryConfig.js (1)

1-1: Migration to MDMS noted. Ensure that all references to deliveryConfig are updated to fetch from MDMS dynamically.

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/AddProductField.js (2)

6-6: Removal of static import aligns with the migration to MDMS.

---

11-16: Use of custom hook useCustomMDMS for dynamic data fetching aligns with the PR objectives to enhance flexibility and maintainability.

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/AddProduct.js (1)

6-6: Update of Toast import source aligns with the changes in the component library structure.

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/deliveryRule/index.js (2)

4-4: Removal of static import aligns with the migration to MDMS.

---

20-31: Use of custom hook useCustomMDMS for dynamic data fetching aligns with the PR objectives to enhance flexibility and maintainability.

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/deliveryRule/AddDeliverycontext.js (2)

16-17: Removal of static imports aligns with the migration to MDMS.

---

Line range hint 40-553: Addition of parameters and variables for attributeConfig and operatorConfig fetched from MDMS enhances the component's adaptability and aligns with the PR objectives.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.