deps: egg-cookies@2 #155
Merged
deps: egg-cookies@2 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead-horse
commented
Nov 22, 2016
| @@ -42,6 +42,6 @@ describe('example cookie test', () => { | |||
| .get('/forget') | |||
| .expect(302) | |||
| .expect('Location', '/') | |||
| .expect('Set-Cookie', /^remember=; path=\/; expires=[^;]+; httponly$/); | |||
| .expect('Set-Cookie', /^remember=; path=\/; expires=[^;]+; httponly,remember\.sig=; path=\/; expires=[^;]+; httponly$/); | |||
There was a problem hiding this comment.
删除 signed cookie 的时候，同时会将签名也删除
dead-horse
force-pushed
the
upgrade-cookies
branch
from
0e635b9 to
90c6e8a
Compare
Current coverage is 97.65% (diff: 100%)@@ master #155 diff @@
==========================================
Files 34 33 -1
Lines 908 853 -55
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 875 833 -42
+ Misses 33 20 -13
Partials 0 0
|
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
升级到 egg-cookies@2，egg 本身已经是做了一定要传 keys 的约定了，egg-cookies@2 修复了 pillarjs/cookies#82 这个问题。如果有人用到了这个 bug 当特性可能会有问题。