Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bugs with Bisect exercise #370

Closed
wants to merge 4 commits into from
Closed

Fixed bugs with Bisect exercise #370

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef188b5
Added configuration for git credentials in setup
TidosDK Aug 7, 2024
8bf583a
Fixed bug in bisect verify.sh
TidosDK Aug 7, 2024
a59cb94
Merge branch 'master' into master
JKrag Nov 4, 2024
59d6ca3
Merge branch 'master' into master
JKrag Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bisect/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
source ../utils/utils.sh

make-exercise-repo
config-local-username
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
make-exercise-repo
config-local-username
pre-setup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config-local-username is better applied through the help function pre-setup, which also takes care of gpg-signature configurations.

And also, we then need a post-setup call at the end of the file, to reset (unset) the robot user, so any future commits will be with own user.
But it seems as if the GH user-interface won't let me add a "suggestion" to lines outside the scope of the original change. Can I ask you to add a post-setup call at the end of the verify.sh script as well?


echo '#! /usr/bin/env bash' > 'test.sh'
echo 'if [[ $(( $(find * | wc -l) + 10 )) -gt 32 ]] ;then' >> 'test.sh'
Expand Down
2 changes: 1 addition & 1 deletion bisect/verify.sh
View file
Open in desktop
JKrag marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#! /usr/bin/env sh

cd exercise
if [[ "$(git log -1 --format='%s' refs/bisect/bad -- )" = '22' ]] ; then
if [ "$(git log -1 --format='%s' refs/bisect/bad -- )" = '22' ] ; then
echo "You managed to find the bad commit with bisect"
else
echo "You have still stuff to do"
Expand Down
Loading