Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to submodules kata about security workaround #366

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions submodules/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@ This allows you to grab source changes directly, as well as _pushing_ them back.

## Setup

> NOTE:
> Unfortunately for us, 2.38.1 introduces a change (due to CVE-2022-39253) that disables git submodule add using the file protocol.
> as the setup script for this exercise relies on cloning a local repository, it will only work if you specifically allow this before running the script.
> `git config --global protocol.file.allow always`
>
> If you want to remove this "openening" afterwards, you should wait until you are done with the whole exercise, and then run:
JKrag marked this conversation as resolved.
Show resolved Hide resolved
> `git config --global --unset protocol.file.allow`

1. Run `source setup.sh` (or `.\setup.ps1` in PowerShell)

> NOTE: If running setup.sh on windows, you can run into problems by sourcing the setup script. Instead, run `./setup.sh`, and the folders would be created correctly.
JKrag marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading