Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CI #145

Merged
merged 8 commits into from
May 6, 2024
Merged

update CI #145

merged 8 commits into from
May 6, 2024

Conversation

kadyb
Copy link
Contributor

@kadyb kadyb commented May 5, 2024

I updated CI exactly the same way as in gstat, but it requires activation in GitHub Actions. I also removed the generated docs directory from pkgdown as the sp Gallery is now hosted, but I don't know if that's ok?

@edzer edzer merged commit 5e9d051 into edzer:main May 6, 2024
5 checks passed
@edzer
Copy link
Owner

edzer commented May 6, 2024

Would it make sense to have a pkgdown site, and move the gallery to a vignette?

@kadyb
Copy link
Contributor Author

kadyb commented May 6, 2024

Probably yes, but I have a question about the current status. How do you treat sp -- it may still be used as an alternative to sf or we should officially move to sf (I mean sp is not recommended anymore)?

@edzer
Copy link
Owner

edzer commented May 6, 2024

Indeed, sp is not recommended anymore. But it also hasn't been deprecated so far, and requires little maintenance (I don't accept new features). There's still around 450 reverse dependencies, and currently if you work with large sets of POINT data sp may have a strong performance benefit over sf - I think that needs to be cleared out before we can start deprecating sp.

edzer added a commit that referenced this pull request May 6, 2024
@kadyb
Copy link
Contributor Author

kadyb commented May 6, 2024

Thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants