chore: add missing course properties in IAP restore & unfulfilled events #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: LEARNER-10309
fixes: LEARNER-10309
farhan-arshad-dev
changed the title
HamzaIsrar12
requested changes
Jan 17, 2025
There was a problem hiding this comment.
We have four additional improvements to address that I forgot to mention in the underline ticket:
- Ensure the unfulfilled flow functions correctly, even when there's only a single course.
- Trigger
CourseUpgradeSuccessregardless of the user's choice on the Unfulfilled Refresh-or-Continue dialog. - Include these properties in the
CourseUpgradeSuccessevent during the unfulfilled flow. - Since the flow sends only one event for all unfulfilled courses, it's better to limit it to one process per session or click to ensure the correct number of
CourseUpgradeSuccessevents are sent.
Thank you!
| purchases.filter { it.accountIdentifiers?.obfuscatedAccountId?.decodeToLong() == userId } | ||
| val userPurchases = purchases.filter { purchase -> | ||
| val userAccountId = purchase.accountIdentifiers?.obfuscatedAccountId?.decodeToLong() | ||
| val storeSku = purchase.accountIdentifiers?.obfuscatedProfileId?.decodeToString() |
There was a problem hiding this comment.
We can use Purchase.getCourseSku() extension function here.
Comment on lines
+131
to
+133
| val courseVerified = enrolledCourses.find { enrolledCourse -> | ||
| enrolledCourse.productInfo?.courseSku == purchase.getCourseSku() | ||
| } |
Comment on lines
+24
to
+26
| suspend fun send(event: EnrolledCourseEvent) = channel.emit(event) | ||
|
|
||
| suspend fun send(event: RequestEnrolledCourseEvent) = channel.emit(event) |
There was a problem hiding this comment.
I think we should rename them and place them in IAPNotifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira: LEARNER-10309