feat: Notifications Inbox Screen #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: LEARNER-10346
Fixes: LEARNER-10346
Fixes: LEARNER-10346
Fixes: LEARNER-10346
Fixes: LEARNER-10346
HamzaIsrar12
force-pushed
the
hamza/LEARNER-10346
branch
from
f51b6de to
8342325
Compare
HamzaIsrar12
requested review from
farhan-arshad-dev,
k1rill,
dixidroid and
omerhabib26
k1rill
reviewed
Jan 6, 2025
notifications/src/main/java/org/openedx/notifications/data/api/APIConstants.kt
Outdated
Show resolved
Hide resolved
...ons/src/main/java/org/openedx/notifications/presentation/inbox/NotificationsInboxFragment.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Some minor concerns.
- Text color doesn't match with the Figma designs of static string like
responded to a post.... - Pull to refresh should be implemented.
- No Quotation marks around the Post title.
- bold Text weight looks higher than the Figma designs.
Agoword needs to be removed after the date as per the Fimga designs.- Sapce should be higher between notification text and date.
notifications/src/main/java/org/openedx/notifications/data/api/APIConstants.kt
Outdated
Show resolved
Hide resolved
notifications/src/main/java/org/openedx/notifications/data/api/NotificationsApi.kt
Show resolved
Hide resolved
notifications/src/main/java/org/openedx/notifications/data/model/InboxNotificationsResponse.kt
Show resolved
Hide resolved
notifications/src/main/java/org/openedx/notifications/data/model/InboxNotificationsResponse.kt
Outdated
Show resolved
Hide resolved
...fications/src/main/java/org/openedx/notifications/data/repository/NotificationsRepository.kt
Outdated
Show resolved
Hide resolved
...ons/src/main/java/org/openedx/notifications/presentation/inbox/NotificationsInboxFragment.kt
Show resolved
Hide resolved
...ons/src/main/java/org/openedx/notifications/presentation/inbox/NotificationsInboxFragment.kt
Outdated
Show resolved
Hide resolved
...ons/src/main/java/org/openedx/notifications/presentation/inbox/NotificationsInboxFragment.kt
Show resolved
Hide resolved
...ons/src/main/java/org/openedx/notifications/presentation/inbox/NotificationsInboxFragment.kt
Show resolved
Hide resolved
...ons/src/main/java/org/openedx/notifications/presentation/inbox/NotificationsInboxFragment.kt
Show resolved
Hide resolved
Fixes: LEARNER-10346
|
Fixes: LEARNER-10345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
LEARNER-10346
A Notification Inbox Screen that organizes notifications into three categories: Recent (last 24 hours), This Week (past 7 days), and Older.
Screenshots:
Figma:
Mobile Notifications UI Screen