Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Casting method update + crash fix #43

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

omerhabib26
Copy link

@omerhabib26 omerhabib26 commented Aug 27, 2024

Description:

  • Update casting method for initialization
  • Release casting onPause()

Note: I was unable to reproduce the issue recorded on Firebase, but it was caused by casting initialization. I have fixed that method.

- Update casting method for initialization
- Release casting onPause()
Copy link
Member

@farhan-arshad-dev farhan-arshad-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to reproduce the app. crash, The Code changes LGTM, and hope the changes will fix the crash.

@farhan-arshad-dev farhan-arshad-dev merged commit b28b6e2 into 2U/develop Sep 4, 2024
4 checks passed
@farhan-arshad-dev farhan-arshad-dev deleted the 2U/omer/LEARNER-10178 branch September 4, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants