Fix field::negate_chain #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug: if the Spell/Trap card that is going to have its activation negated leaves and returns to the field before the function is executed, it should not be sent to the GY when the the negation occurs because it is, for the game state, a different copy of the card. proposed solution: check for the chain relation before setting the leave_confirmed status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Spell/Trap card that is going to have its activation negated leaves the field but it is put back in the S/T zone before this function (
field::negate_chain) is executed, it should not be sent to the GY when the negation occurs because it is treated as a different copy of the card. Currently it will be sent to the GY, which is wrongThis pull requests adds an extra check for the chain relation before setting the status to the card