Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Provision Watchers tab to Metadata #630

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

A808597949
Copy link

@A808597949 A808597949 commented Aug 22, 2023

show provision watcher list
add a new provision watcher
edit a provision watcher
delete a provision watcher

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-ui-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@cloudxxx8
Copy link
Member

@A808597949 @Ambition-J
Could anyone of your team member help review the PR? We don't have Angular expertise to review this.
There is another PR with the same name. Is there any duplication?
#625

@jumpingliu for awareness

@A808597949
Copy link
Author

The submission at #625 does not meet the standard, so I have resubmitted it.

@cloudxxx8
Copy link
Member

recheck

@cloudxxx8
Copy link
Member

@A808597949 the make test fails, so the validation cannot be passed
please adjust the code to make sure make test can be passed

Signed-off-by: wei.jin <[email protected]>
@A808597949
Copy link
Author

@cloudxxx8 I have adjusted the code, and now 'make test' passes successfully.

@cloudxxx8
Copy link
Member

The Jenkins automation validation is still failed. Do you have any ideas about the following error?
@ernestojeda is there anything to do from DevOps for the npm upgrade?

[2023-09-04T02:39:07.381Z] npm ERR! code EBADENGINE
[2023-09-04T02:39:07.381Z] npm ERR! engine Unsupported engine
[2023-09-04T02:39:07.381Z] npm ERR! engine Not compatible with your version of node/npm: [email protected]
[2023-09-04T02:39:07.381Z] npm ERR! notsup Not compatible with your version of node/npm: [email protected]
[2023-09-04T02:39:07.381Z] npm ERR! notsup Required: {"node":"^18.17.0 || >=20.5.0"}
[2023-09-04T02:39:07.381Z] npm ERR! notsup Actual: {"npm":"8.15.0","node":"v16.17.1"}
[2023-09-04T02:39:07.381Z]
[2023-09-04T02:39:07.381Z] npm ERR! A complete log of this run can be found in:
[2023-09-04T02:39:07.381Z] npm ERR! /root/.npm/_logs/2023-09-04T02_39_06_760Z-debug-0.log
[2023-09-04T02:39:07.381Z] The command '/bin/sh -c npm install -g npm' returned a non-zero code: 1
[2023-09-04T02:39:07.381Z] make[1]: *** [Makefile:82: edgex-web-ui.imagebuilt] Error 1

https://jenkins.edgexfoundry.org/blue/organizations/jenkins/edgexfoundry%2Fedgex-ui-go/detail/PR-630/3/pipeline/

@ernestojeda
Copy link
Contributor

@cloudxxx8 I think all that needs to be done is change this line: https://github.com/edgexfoundry/edgex-ui-go/blob/main/web/Dockerfile#L1 to a newer version of NodeJS. 18 or 20 should work: https://hub.docker.com/_/node

@cloudxxx8
Copy link
Member

@A808597949 could you please make the change based on @ernestojeda 's suggestion?

@A808597949
Copy link
Author

I tried changing the version of Node.js, but I encountered errors when running 'make test' locally. I'm currently looking for a solution.

@cloudxxx8
Copy link
Member

@A808597949 do you have any progress for this PR?
this is blocking #632

@A808597949
Copy link
Author

I will try it

@cloudxxx8
Copy link
Member

please help rebase first

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve based on @Ambition-J 's review

@cloudxxx8 cloudxxx8 merged commit f65144e into edgexfoundry:main Sep 27, 2023
4 checks passed
@lenny-goodell
Copy link
Member

@A808597949 please see #642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants