-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Provision Watchers tab to Metadata #630
Conversation
Signed-off-by: wei.jin <[email protected]>
Signed-off-by: wei.jin <[email protected]>
@A808597949 @Ambition-J @jumpingliu for awareness |
The submission at #625 does not meet the standard, so I have resubmitted it. |
recheck |
@A808597949 the |
Signed-off-by: wei.jin <[email protected]>
@cloudxxx8 I have adjusted the code, and now 'make test' passes successfully. |
The Jenkins automation validation is still failed. Do you have any ideas about the following error?
|
@cloudxxx8 I think all that needs to be done is change this line: https://github.com/edgexfoundry/edgex-ui-go/blob/main/web/Dockerfile#L1 to a newer version of NodeJS. 18 or 20 should work: https://hub.docker.com/_/node |
@A808597949 could you please make the change based on @ernestojeda 's suggestion? |
I tried changing the version of Node.js, but I encountered errors when running 'make test' locally. I'm currently looking for a solution. |
@A808597949 do you have any progress for this PR? |
I will try it |
please help rebase first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve based on @Ambition-J 's review
@A808597949 please see #642 |
show provision watcher list
add a new provision watcher
edit a provision watcher
delete a provision watcher
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-ui-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)