-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update default database to PostgreSQL in v4 #4981
Conversation
Resolves edgexfoundry#4980. Update default database, msg bus, config provider and registry host. Remove support-scheduler code. Signed-off-by: Lindsey Cheng <[email protected]>
Fix unit test failure. Signed-off-by: Lindsey Cheng <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4981 +/- ##
==========================================
- Coverage 30.74% 29.35% -1.39%
==========================================
Files 266 249 -17
Lines 19680 18676 -1004
==========================================
- Hits 6051 5483 -568
+ Misses 12295 11948 -347
+ Partials 1334 1245 -89 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modify the configuration file of support-cron-scheduler to use the commom config database setting.
it doesn't need to use its own anymore
Remove Database Name field in the private config. Signed-off-by: Lindsey Cheng <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #4980. Update default database, msg bus, config provider and registry host. Remove support-scheduler code.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)