Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update default database to PostgreSQL in v4 #4981

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

lindseysimple
Copy link
Contributor

Resolves #4980. Update default database, msg bus, config provider and registry host. Remove support-scheduler code.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Resolves edgexfoundry#4980. Update default database, msg bus, config provider and registry host.
Remove support-scheduler code.

Signed-off-by: Lindsey Cheng <[email protected]>
Fix unit test failure.

Signed-off-by: Lindsey Cheng <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.35%. Comparing base (ead5599) to head (b91dd63).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4981      +/-   ##
==========================================
- Coverage   30.74%   29.35%   -1.39%     
==========================================
  Files         266      249      -17     
  Lines       19680    18676    -1004     
==========================================
- Hits         6051     5483     -568     
+ Misses      12295    11948     -347     
+ Partials     1334     1245      -89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify the configuration file of support-cron-scheduler to use the commom config database setting.
it doesn't need to use its own anymore

cmd/support-notifications/res/configuration.yaml Outdated Show resolved Hide resolved
Remove Database Name field in the private config.

Signed-off-by: Lindsey Cheng <[email protected]>
Copy link

sonarcloud bot commented Oct 25, 2024

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit c89e7d4 into edgexfoundry:main Oct 25, 2024
6 checks passed
@cloudxxx8 cloudxxx8 deleted the issue-4980 branch October 25, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update default database to PostgreSQL in Common Config in V4
3 participants