Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move API document files from openapi/v3 to openapi #4979

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

cherrycl
Copy link
Contributor

Closes #4978

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@cherrycl cherrycl changed the title feat: Move API document files from openapi/v3 to openapi fix: Move API document files from openapi/v3 to openapi Oct 22, 2024
cloudxxx8
cloudxxx8 previously approved these changes Oct 22, 2024
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8
Copy link
Member

@cherrycl please rebase to the latest main branch

Copy link

sonarcloud bot commented Oct 22, 2024

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.74%. Comparing base (b42af75) to head (c7c3680).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4979   +/-   ##
=======================================
  Coverage   30.74%   30.74%           
=======================================
  Files         266      266           
  Lines       19680    19680           
=======================================
  Hits         6051     6051           
  Misses      12295    12295           
  Partials     1334     1334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cloudxxx8 cloudxxx8 merged commit ead5599 into edgexfoundry:main Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put API document files under openapi
3 participants