Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the force query param to add device metadata API #4929

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

lindseysimple
Copy link
Contributor

@lindseysimple lindseysimple commented Oct 1, 2024

Resolves #4694. Add the force query param to add device metadata API.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Resolves edgexfoundry#4694. Add the force query param to add device metadata API.

Signed-off-by: Lindsey Cheng <[email protected]>
internal/pkg/infrastructure/postgres/device.go Outdated Show resolved Hide resolved
internal/core/metadata/application/device.go Outdated Show resolved Hide resolved
internal/core/metadata/application/device.go Outdated Show resolved Hide resolved
- Rename forceAddDevice func to update Device
- Publish update device system event for force add

Signed-off-by: Lindsey Cheng <[email protected]>
Copy link

sonarcloud bot commented Oct 2, 2024

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 1033d52 into edgexfoundry:main Oct 2, 2024
6 checks passed
@cloudxxx8 cloudxxx8 deleted the issue-4694 branch October 2, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core Metadata] Handle plugged devices moving from one node to another node
2 participants