Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add core-metadata device/provisionwatcher db methods for postgres #4923

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

jinlinGuan
Copy link
Contributor

close #4909

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 254 lines in your changes missing coverage. Please review.

Project coverage is 34.50%. Comparing base (08e30e9) to head (fd73939).

Files with missing lines Patch % Lines
internal/pkg/infrastructure/postgres/device.go 0.00% 132 Missing ⚠️
...l/pkg/infrastructure/postgres/provision_watcher.go 0.00% 120 Missing ⚠️
...rnal/pkg/infrastructure/postgres/device_profile.go 0.00% 1 Missing ⚠️
...rnal/pkg/infrastructure/postgres/device_service.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4923      +/-   ##
==========================================
- Coverage   35.05%   34.50%   -0.56%     
==========================================
  Files         131      131              
  Lines       12930    13138     +208     
==========================================
  Hits         4533     4533              
- Misses       8003     8211     +208     
  Partials      394      394              
Flag Coverage Δ
34.50% <0.00%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 26, 2024

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit b97f2c8 into edgexfoundry:main Sep 26, 2024
6 checks passed
@jinlinGuan jinlinGuan deleted the issue-4909-metadata branch September 26, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Core Metadata to support PostgreSQL as persistence layer
3 participants