Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the Keeper registry db methods for Postgres #4914

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

lindseysimple
Copy link
Contributor

@lindseysimple lindseysimple commented Sep 13, 2024

Resolves #4877. Add the Keeper registry db methods for Postgres.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Resolves edgexfoundry#4877. Add the Keeper registry db methods for Postgres.

Signed-off-by: Lindsey Cheng <[email protected]>
Copy link

sonarcloud bot commented Sep 13, 2024

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 4.04040% with 95 lines in your changes missing coverage. Please review.

Project coverage is 36.92%. Comparing base (2694c23) to head (a8bb910).

Files with missing lines Patch % Lines
internal/pkg/infrastructure/postgres/registry.go 0.00% 83 Missing ⚠️
internal/pkg/infrastructure/postgres/sql.go 0.00% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4914      +/-   ##
==========================================
- Coverage   37.17%   36.92%   -0.26%     
==========================================
  Files         125      125              
  Lines       12184    12276      +92     
==========================================
+ Hits         4530     4533       +3     
- Misses       7260     7349      +89     
  Partials      394      394              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 475a7db into edgexfoundry:main Sep 13, 2024
6 checks passed
@cloudxxx8 cloudxxx8 deleted the issue-4877-2 branch September 13, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Core Keeper to support PostgreSQL as persistence layer
3 participants