Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update core-metadata.yaml for missing tags and description' #4612

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

jumpingliu
Copy link
Contributor

@jumpingliu jumpingliu commented Jul 19, 2023

close #4611

ref: https://github.com/edgexfoundry/go-mod-core-contracts/pull/783/files

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #4612 (0622ab8) into main (e66fa62) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4612   +/-   ##
=======================================
  Coverage   41.49%   41.49%           
=======================================
  Files         105      105           
  Lines        9719     9719           
=======================================
  Hits         4033     4033           
  Misses       5343     5343           
  Partials      343      343           

@lenny-goodell lenny-goodell changed the title fix: Update core-metadata.yaml for missing tabs and description' fix: Update core-metadata.yaml for missing tags and description' Jul 19, 2023
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 54d035b into edgexfoundry:main Jul 19, 2023
7 checks passed
@jumpingliu jumpingliu deleted the issue-4611 branch July 20, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags field in DeviceCommand is missing
3 participants