fix: Address review comment

Signed-off-by: Jack Chen <[email protected]>

internal/support/cronscheduler/infrastructure/interfaces/SchedulerManager.go

@@ -17,7 +17,7 @@ type SchedulerManager interface {
 	StartScheduleJobByName(name, correlationId string) errors.EdgeX
 	StopScheduleJobByName(name, correlationId string) errors.EdgeX
 	TriggerScheduleJobByName(name, correlationId string) errors.EdgeX
-	ValidateScheduleJob(job models.ScheduleJob) errors.EdgeX
+	ValidateUpdatingScheduleJob(job models.ScheduleJob) errors.EdgeX
 
 	Shutdown(correlationId string) errors.EdgeX
 }

internal/support/cronscheduler/infrastructure/manager.go

@@ -73,13 +73,8 @@ func (m *manager) AddScheduleJob(job models.ScheduleJob, correlationId string) e
 
 // UpdateScheduleJob updates a ScheduleJob in the scheduler manager
 func (m *manager) UpdateScheduleJob(job models.ScheduleJob, correlationId string) errors.EdgeX {
-	_, err := m.getSchedulerByJobName(job.Name)
-	if err != nil {
-		return errors.NewCommonEdgeXWrapper(err)
-	}
-
 	// Validate the ScheduleJob before updating it
-	if err := m.ValidateScheduleJob(job); err != nil {
+	if err := m.ValidateUpdatingScheduleJob(job); err != nil {
 		return errors.NewCommonEdgeX(errors.KindContractInvalid, "failed to validate the scheduled job", err)
 	}
 
@@ -178,8 +173,8 @@ func (m *manager) Shutdown(correlationId string) errors.EdgeX {
 	return nil
 }
 
-// ValidateScheduleJob validates the ScheduleJob that will be updated, this function mainly checks the definition and actions of the ScheduleJob with gocron
-func (m *manager) ValidateScheduleJob(job models.ScheduleJob) errors.EdgeX {
+// ValidateUpdatingScheduleJob validates the ScheduleJob that will be updated, this function mainly checks the definition and actions of the ScheduleJob with gocron
+func (m *manager) ValidateUpdatingScheduleJob(job models.ScheduleJob) errors.EdgeX {
 	if job.Name == "" && job.Id == "" {
 		return errors.NewCommonEdgeX(errors.KindContractInvalid, "name or ID is required", nil)
 	}

internal/support/cronscheduler/infrastructure/manager_test.go

@@ -99,7 +99,7 @@ func validScheduleJob() models.ScheduleJob {
 	}
 }
 
-func TestValidateScheduleJob(t *testing.T) {
+func TestValidateUpdatingScheduleJob(t *testing.T) {
 	dic := mockDic()
 	mockManager := NewManager(dic)
 
@@ -148,7 +148,7 @@ func TestValidateScheduleJob(t *testing.T) {
 	}
 	for _, testCase := range tests {
 		t.Run(testCase.name, func(t *testing.T) {
-			err := mockManager.ValidateScheduleJob(testCase.job)
+			err := mockManager.ValidateUpdatingScheduleJob(testCase.job)
 			if testCase.expectedError {
 				assert.Error(t, err)
 			} else {