-
-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added mdBook/GitBook/MkDocs icons #793 #827
base: master
Are you sure you want to change the base?
Conversation
please review |
@HemanthTigga You've ticked the box that says the images are under 1KB. But two of the images are much larger. Why is that? Additionally, they don't look like all the other icons, do they? Please correct them. Ask questions if you need to. |
How do i scale down viewbox because if i use 0 0 512 512, the image just overflows. How do i fix it? |
You can try using Yann Armelin's SVG Path Editor, svgo, and svgcleaner. |
Thanks! I'll try these right away. |
updated the viewbox of all three files |
@HemanthTigga Have you read the Contributing guide?
|
I tried reducing the size but that's as far as I could go. |
Take a look at the viewbox of gitBook - it's set to 6500! Reduce that and scale the image. That should help. Perhaps delete the others and come back when you understand a bit more about what you're doing? |
@HemanthTigga Any updates? |
Thank you for your contribution! Before sending this Pull Request, please confirm the following:
If you have done the above, please send the Pull Request.