Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mdBook/GitBook/MkDocs icons #793 #827

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

HemanthTigga
Copy link

Thank you for your contribution! Before sending this Pull Request, please confirm the following:

  • You have read the contributing guidelines
  • The icon's size is under 1,024 Bytes
  • The layout of the SVG looks like this including newlines
<svg xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><path
d="m0 0H512V512H0"
fill="#fff"/> ... </svg>

If you have done the above, please send the Pull Request.

@HemanthTigga
Copy link
Author

please review

@edent
Copy link
Owner

edent commented Oct 2, 2024

@HemanthTigga You've ticked the box that says the images are under 1KB. But two of the images are much larger. Why is that?

Additionally, they don't look like all the other icons, do they?

Please correct them. Ask questions if you need to.

@HemanthTigga
Copy link
Author

How do i scale down viewbox because if i use 0 0 512 512, the image just overflows. How do i fix it?

@edent
Copy link
Owner

edent commented Oct 3, 2024

You can try using Yann Armelin's SVG Path Editor, svgo, and svgcleaner.

@HemanthTigga
Copy link
Author

Thanks! I'll try these right away.

@HemanthTigga
Copy link
Author

updated the viewbox of all three files

@edent
Copy link
Owner

edent commented Oct 3, 2024

@HemanthTigga Have you read the Contributing guide?

  • gitBook is 1.15 KB
  • mdBook won't fit in the guidelines
  • mkDocs is 2.05 KB and doesn't look like their official logo

@HemanthTigga
Copy link
Author

I tried reducing the size but that's as far as I could go.

@edent
Copy link
Owner

edent commented Oct 3, 2024

Take a look at the viewbox of gitBook - it's set to 6500! Reduce that and scale the image. That should help.

Perhaps delete the others and come back when you understand a bit more about what you're doing?

@edent
Copy link
Owner

edent commented Oct 21, 2024

@HemanthTigga Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants