Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geeks for geeks logo #815

Closed
wants to merge 0 commits into from
Closed

Conversation

ohmschrodinger
Copy link
Contributor

No description provided.

@Eiim
Copy link
Collaborator

Eiim commented Oct 1, 2024

A few comments:

  • Your logo doesn't follow the SVG layout provided in CONTRIBUTING.md:
<svg xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><path
d="m0 0H512V512H0"
fill="#fff"/> ... </svg>
  • You shouldn't update CONTRIBUTING.md to mark off what you've done - just use it as a guide

  • I'm not sure what the reason for the change in the Python script is - if something needs changed there, it should be in a separate pull request, otherwise you don't need to touch it.

@ohmschrodinger
Copy link
Contributor Author

ohmschrodinger commented Oct 2, 2024

Okay ill update the svg layout

About python script-
Screenshot 2024-10-01 231019

this is the error im getting with the original script

@ohmschrodinger
Copy link
Contributor Author

Could you please share the reason for the spam label on this PR? I’d like to improve my contributions. Thank you!

@edent
Copy link
Owner

edent commented Oct 17, 2024

@ohmschrodinger It is to discourage Hacktoberfest spam. Your PR didn't follow the guidelines and you hadn't updated it for a couple of weeks.

@ohmschrodinger
Copy link
Contributor Author

I understand, thanks for the clarification. I'm still working on the logo. The file size I have right now is 1.6KB, and I'm working to reduce it to 1KB as per the project guidelines.

@edent edent removed the spam label Oct 17, 2024
@edent
Copy link
Owner

edent commented Oct 17, 2024

I've removed the spam label. Feel free to discuss your logo in the issues.

@ohmschrodinger
Copy link
Contributor Author

Thank you! I'll send a PR as soon as the task is finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants