Script update for references and checks #770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like this idea. Looks good. What more work does it need? |
|
Just wanted to confirm the location of the files and that the html was good. Also, should I remove the reference/index.md and just use the REFERENCES.md file perhaps? |
* Add Webtoons * Updated readme & reference * Fixed extra Webtoons listing in readme * Applied Eiim's optimizations & increased accuracy
* Create justgiving.svg * do other tasks according to guidelines * add readme and reference changes back in
* add Apple Podcasts logo * add Apple Podcasts reference image * update reference index with Apple Podcast images * updates README (via python script) * fix: adds required attribute in stop element * update README.md Rerun python script to update README.md after correcting Apple Podcasts svg.
* ok.ru 615 B → 351 B Uses strokes to draw shapes instead of complex path outlines. Shrinks file size by 264 bytes. Also corrects color to match icon from ok.ru website. * updates README.md with new, smaller ok.ru file size --------- Co-authored-by: Terence Eden <[email protected]>
* add bluesky.svg derived from https://bsky.app/static/safari-pinned-tab.svg * fix aria-label/role for bluesky.svg * Update bluesky.svg Fix role & layout --------- Co-authored-by: Terence Eden <[email protected]>
* add h-card icon * add h-card reference image * update image reference index * update README.md using python script
* Optimize some SVG paths * Update icons sizes in README
|
Sorry for the delay. I'm happy with this. If you could please rebase it, I'll merge. |
Minified
* Add NetBSD (937 bytes) * Update netbsd.svg --------- Co-authored-by: Terence Eden <[email protected]>
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
I think I've fixed it... but may have screwed things up completely! If this doesn't work then I can delete the PR and start a new branch copying the script over. |
|
Yeah... let's start on a new branch 😂 |
|
I think that's for the best! I'll play around with it when I have some time! |
|
Re-opened as #799 which is hopefully less messy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the update_readme.py to keep a REFERENCES.md and a CHECK.html file updated.
A working example of the check html file is here: https://jmb.github.io/SuperTinyIcons/CHECK.html - it shows the SVG icon with border=50% so that any that don't fit the circle are easily recognised.
It currently looks for reference images with the same base name as the svg, then checks the images/reference/index.md for the source location and any other reference images that might have a different name. Eventually this check should probably be moved to look at the REFERENCES.md file and the index.md removed.
PR presented for evaluation with the understanding that tweaks will likely need to be made! Thanks!