feat: ✨ added svg for c language #762
Conversation
|
I'm not sure if its intentional but the colours don't seem to quite match the reference image. |
|
Hey @jmb, I have updated the reference image with the exact colors as SVG. Also, I have regenerated the README using the Python script. |
|
A couple more comments I'm afraid - the triangle that is on the right hand side between the two ends of the 'C' is missing and the corners between the current two coloured areas don't line up. |
Fixed the triangle issue. |
|
I think you should be matching the svg icon to the reference image (which was suggested to be the same as the C++ logo without the ++ and is on Wikimedia here: https://commons.wikimedia.org/wiki/File:C_Programming_Language.svg ) not adjusting the reference image to your svg. You need to to make sure the svg icon fits inside the green circle on the guideline template and it has the white background (in this case). The easiest option would be to take the cplusplus.svg file and remove the paths that make up the ++ 😉 |
|
@AnkurBansal18 are you going to continue this PR? |
|
Hey, sure I will complete this by tomorrow. Was busy in some other work.
…On Sat, Oct 14, 2023, 3:35 PM Jonathan Batchelor ***@***.***> wrote:
@AnkurBansal18 <https://github.com/AnkurBansal18> are you going to
continue this PR?
—
Reply to this email directly, view it on GitHub
<#762 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOF6MTH6AOHCNWF6ZX52IA3X7JPWLANCNFSM6AAAAAA5SD46WA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
what does this PR do ?
This PR introduces the SVG for C language.
Fixes #719
##Checklist (according to CONTRIBUTING.md)
--my filename structure follows (Filename should be nameofservice.svg )
-- my icon follows and fits under icon size guidelines
-- my codes updated the readme using edit readme using python3 generate_readme_table.py
-- I have added the reference image
-- I have edited reference page