Added dot product from Annoy c++ source #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
reviewed
Aug 3, 2024
eddelbuettel
approved these changes
Aug 3, 2024
I am not too concerned: this only adds new functionality in a way that should not affect existing functionality.
I will admit to having missed that. |
Perfect, just pushed commit. |
|
Turns out we forgot one microaspect of an added alias for the Rd file. I just took care of that in 6446e7b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed Annoy has the dot product distance and wrote a quick drop-in interface. I don't know if this breaks things downstream but wanted to see if there was interest in adding this to the API.