-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make adding new versions easier #232
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you so much @HagerDakroury 🙏🏽 This will indeed make a very big difference for ontology maintainers🙌🏽
One last thing before merge: @HagerDakroury, would you please rename the file to anything you agreed on with @bryan-brancotte, such as 'ontoBrowserConfig.js' or 'configOntoBrowser.js' or similar, shorter/longer... Million thanks! 🙏🏽🙇🏽♂️
(because if we renamed it later, the history might not be properly visible on GitHub)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤
@bryan-brancotte has suggested moving this part to the config file as well, as its edam-specific |
Checklist
Details
During a discussion with @matuskalas last week, we agreed that it'll be for the best if we tried to put all hard-coded values related to the versions (links, the order in dropdown menu, labels, etc.) in one file.
The goal behind that is to have the possibility of adding a new version and updating existing ones (like "stable" to 1.26 instead of 1.25) be as seamless as possible, with just one or 2 lines change.
This PR achieves that.
To test/add a new version:
That's it! Example of adding 1.22: