Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-1846] Onboarding UI fixes #572

Merged
merged 4 commits into from
Oct 11, 2023
Merged

[MOB-1846] Onboarding UI fixes #572

merged 4 commits into from
Oct 11, 2023

Conversation

lucaschifino
Copy link
Collaborator

@lucaschifino lucaschifino commented Oct 10, 2023 •
edited
Loading

MOB-1846

Context

Follow-up of #526, where two UI improvements were reported.

Approach

  • Updated the design for step 1 with incentivised search so that they all look the same regardless of the content displayed which is specific to a market.
    • Re-used WelcomeTourGreen since they are mostly the same, just supporting a counter card instead of the green card.
  • Remove chevron image from step 4 financial reports dropdown

d4r1091
d4r1091 previously approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@d4r1091 d4r1091 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers 👌 🟢
Approving code-wise and look forward to reapprove with the new image

Client/Ecosia/UI/Onboarding/WelcomeTourGreen.swift Outdated Show resolved Hide resolved
@d4r1091 d4r1091 self-requested a review October 10, 2023 15:02
@lucaschifino lucaschifino marked this pull request as ready for review October 11, 2023 12:09
@lucaschifino lucaschifino requested a review from a team October 11, 2023 12:10
d4r1091
d4r1091 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@d4r1091 d4r1091 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@lucaschifino lucaschifino merged commit c23acb3 into main Oct 11, 2023
2 checks passed
@lucaschifino lucaschifino deleted the MOB-1846_onboarding_ui_fixes branch October 11, 2023 12:45
@lucaschifino lucaschifino mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4r1091 d4r1091 d4r1091 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucaschifino @d4r1091