-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buffer zero size alloc #137
Conversation
fix test and add new test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #137 +/- ##
===========================================
- Coverage 63.80% 63.72% -0.08%
===========================================
Files 1069 1065 -4
Lines 55387 55156 -231
Branches 4100 4084 -16
===========================================
- Hits 35337 35149 -188
+ Misses 20050 20007 -43 ☔ View full report in Codecov by Sentry. |
Private downstream CI failed. |
Private downstream CI failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks uncontroversial to me :)
Private downstream CI failed. |
Private downstream CI succeeded. |
2 similar comments
Private downstream CI succeeded. |
Private downstream CI succeeded. |
In eckit::Buffer default ctor (size=0), buffer_ is allocated as 'new char[0]'.
'buffer.data() != nullptr', which is not a correct state for an uninitialized buffer