Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer zero size alloc #137

Closed
wants to merge 10 commits into from
Closed

Buffer zero size alloc #137

wants to merge 10 commits into from

Conversation

mcakircali
Copy link
Contributor

In eckit::Buffer default ctor (size=0), buffer_ is allocated as 'new char[0]'.

'buffer.data() != nullptr', which is not a correct state for an uninitialized buffer

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.72%. Comparing base (8d230b1) to head (3d6e286).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #137      +/-   ##
===========================================
- Coverage    63.80%   63.72%   -0.08%     
===========================================
  Files         1069     1065       -4     
  Lines        55387    55156     -231     
  Branches      4100     4084      -16     
===========================================
- Hits         35337    35149     -188     
+ Misses       20050    20007      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 8, 2024

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9845331440.

Copy link

github-actions bot commented Jul 8, 2024

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9845621725.

Copy link
Member

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks uncontroversial to me :)

Copy link

github-actions bot commented Sep 4, 2024

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10706093266.

Copy link

github-actions bot commented Sep 4, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10706238996.

2 similar comments
Copy link

github-actions bot commented Sep 4, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10706238996.

Copy link

github-actions bot commented Sep 4, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10706238996.

@mcakircali mcakircali closed this Sep 5, 2024
@mcakircali mcakircali deleted the fix/buffer-zero-alloc branch September 5, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants