Tidy up some clang warnings

ecmwf · Aug 28, 2023 · ffdee81 · ffdee81
1 parent de68dd7
commit ffdee81
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/eckit/parser/YAMLParser.cc b/src/eckit/parser/YAMLParser.cc
@@ -25,8 +25,6 @@
 
 namespace eckit {
 
-static Value toValue(const std::string& s);
-
 struct YAMLItem : public Counted {
 
     long indent_;

diff --git a/tests/utils/test_optional.cc b/tests/utils/test_optional.cc
@@ -122,12 +122,18 @@ CASE("copy and move assign") {
         EXPECT(!opt3);
 
         // Self move-assignement
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wself-move"
         opt2 = std::move(opt2);
+#pragma clang diagnostic pop
         EXPECT(opt2);
         EXPECT(opt2.value() == 2);
 
         // Self copy-assignement
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wself-assign-overloaded"
         opt2 = opt2;
+#pragma clang diagnostic pop
         EXPECT(opt2);
         EXPECT(opt2.value() == 2);
 
@@ -192,7 +198,10 @@ CASE("non-trivial object: std::string") {
 
         // Test move assign to self
         Optional<std::string> optTmp4("tmp4");
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wself-move"
         optTmp4 = std::move(optTmp4);
+#pragma clang diagnostic pop
         EXPECT(optTmp4);
         EXPECT_EQUAL(optTmp4.value(), std::string("tmp4"));