-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
40 support dataset with missing timesteps #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Magnus Sikora <[email protected]>
mchantry
reviewed
Sep 5, 2024
mchantry
reviewed
Sep 5, 2024
Magnus-SI
reviewed
Sep 6, 2024
Co-authored-by: Magnus Sikora <[email protected]>
Co-authored-by: Magnus Sikora <[email protected]>
Co-authored-by: Magnus Sikora <[email protected]>
…m:ecmwf/anemoi-training into 40-support-dataset-with-missing-timesteps
JPXKQX
dismissed
mchantry’s stale review
September 12, 2024 10:31
The merge-base changed after approval.
mchantry
previously approved these changes
Sep 12, 2024
mchantry
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR introduces support for datasets with missing timesteps.
A "valid_times" attribute is added to the NativeGridDataset. This attribute contains the indices of the samples valid for training. It is computed based on 4 parameters:
Please also include relevant motivation and context.
We need to support training with datasets containing missing time steps.
List any dependencies that are required for this change.
No new dependencies.
Type of change
Please delete options that are not relevant.
Issue ticket number and link
Issue #40
Checklist before requesting a review
Thanks to @Magnus-SI and the rest of the MetNorway team for their contribution to this feature.