Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

40 support dataset with missing timesteps #48

Merged
merged 18 commits into from
Sep 13, 2024

Conversation

JPXKQX
Copy link
Member

@JPXKQX JPXKQX commented Sep 4, 2024

Describe your changes
This PR introduces support for datasets with missing timesteps.

A "valid_times" attribute is added to the NativeGridDataset. This attribute contains the indices of the samples valid for training. It is computed based on 4 parameters:

  • Number of input timesteps.
  • Steps to roll out.
  • Time increments.
  • Missing timesteps, if any.

Please also include relevant motivation and context.
We need to support training with datasets containing missing time steps.

List any dependencies that are required for this change.
No new dependencies.

Type of change
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Issue ticket number and link
Issue #40

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation and docstrings to reflect the changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have ensured that the code is still pip-installable after the changes and runs
  • I have not introduced new dependencies in the inference partion of the model
  • I have run this on a single GPU
  • I have run this on multi-GPU or multi-node
  • I have run this to work on LUMI (or made sure the changes work independently.)
  • I have run the Benchmark Profiler against the old version of the code

Thanks to @Magnus-SI and the rest of the MetNorway team for their contribution to this feature.

@JPXKQX JPXKQX added the enhancement New feature or request label Sep 4, 2024
@JPXKQX JPXKQX self-assigned this Sep 4, 2024
@JPXKQX JPXKQX linked an issue Sep 4, 2024 that may be closed by this pull request
@FussyDuck
Copy link

FussyDuck commented Sep 4, 2024

CLA assistant check
All committers have signed the CLA.

CHANGELOG.md Outdated Show resolved Hide resolved
@JPXKQX JPXKQX dismissed mchantry’s stale review September 12, 2024 10:31

The merge-base changed after approval.

mchantry
mchantry previously approved these changes Sep 12, 2024
Copy link
Member

@mchantry mchantry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, approved.

@JPXKQX JPXKQX merged commit 91d8c6e into develop Sep 13, 2024
61 of 105 checks passed
@JPXKQX JPXKQX deleted the 40-support-dataset-with-missing-timesteps branch September 13, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dataset with missing timesteps
4 participants