Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename frequency to batch_frequency in RolloutEval #118

Merged
merged 8 commits into from
Nov 6, 2024

Conversation

HCookie
Copy link
Member

@HCookie HCookie commented Oct 30, 2024

No description provided.

@HCookie HCookie self-assigned this Oct 30, 2024
@HCookie
Copy link
Member Author

HCookie commented Oct 30, 2024

No changelog update needed for this PR

mc4117
mc4117 previously approved these changes Oct 30, 2024
@HCookie HCookie requested a review from mchantry November 5, 2024 10:38
@HCookie HCookie added the no changelog Flag a PR as not requiring a changelog update label Nov 5, 2024
@JesperDramsch
Copy link
Member

No changelog update needed for this PR

This changes the default values in a config. Should this really not be mentioned in the changelog?

@HCookie HCookie removed the no changelog Flag a PR as not requiring a changelog update label Nov 6, 2024
Copy link
Member

@JesperDramsch JesperDramsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the patience with my silly naming requests

@JesperDramsch JesperDramsch merged commit 7ec2e38 into develop Nov 6, 2024
115 of 116 checks passed
@JesperDramsch JesperDramsch deleted the fix/rename-to-batch_frequency branch November 6, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants