Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for transformer conv inference and doc string #4

Merged
merged 5 commits into from
Jun 10, 2024
Merged

fix for transformer conv inference and doc string #4

merged 5 commits into from
Jun 10, 2024

Conversation

ssmmnn11
Copy link
Member

@ssmmnn11 ssmmnn11 commented Jun 8, 2024

  • add doc string reference to paper for transformer conv
  • fix inference bug in gnn transformer block

@FussyDuck
Copy link

FussyDuck commented Jun 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ssmmnn11 ssmmnn11 added the bug Something isn't working label Jun 8, 2024
JesperDramsch
JesperDramsch approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@JesperDramsch JesperDramsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some minor changes, apart from that lgtm

@ssmmnn11 ssmmnn11 merged commit e683e87 into develop Jun 10, 2024
4 of 5 checks passed
@ssmmnn11 ssmmnn11 deleted the feature/trconv-fix branch June 10, 2024 13:44
JesperDramsch added a commit that referenced this pull request Jun 10, 2024
@JesperDramsch
Revert "fix for transformer conv inference and doc string (#4)"
7aa72c2 
This reverts commit e683e87.
@JesperDramsch JesperDramsch mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesperDramsch JesperDramsch JesperDramsch approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssmmnn11 @FussyDuck @JesperDramsch