Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/52 error subclass metadata specific must be implemented in derived class cropping #53

Conversation

JPXKQX
Copy link
Member

@JPXKQX JPXKQX commented Sep 24, 2024

This PR implements a bug fix for Issue #52 .

@FussyDuck
Copy link

FussyDuck commented Sep 24, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (647e216) to head (ea6b0c2).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #53   +/-   ##
========================================
  Coverage    88.83%   88.83%           
========================================
  Files            9        9           
  Lines          761      761           
========================================
  Hits           676      676           
  Misses          85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@b8raoult b8raoult merged commit 6331014 into develop Sep 24, 2024
109 of 117 checks passed
@b8raoult b8raoult deleted the bugfix/52-error-subclass_metadata_specific-must-be-implemented-in-derived-class-cropping branch September 24, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants