Initial FreeformInputWidget #48
Conversation
|
|
src/widgets/FreeformInputWidget.tsx
Outdated
| /** | ||
| * Permitted selections for the widget. | ||
| */ | ||
| constraints?: string[] |
There was a problem hiding this comment.
I think we can get rid of this for now if constraints are not going to be already applied to this widget.
There was a problem hiding this comment.
Dropped constraints for the moment, also bypass and all dependencies of constraints.
| @@ -0,0 +1,366 @@ | |||
| import React from 'react' | |||
|
|
|||
| import { FreeformInputWidget, TooltipProvider } from '../../src' | |||
There was a problem hiding this comment.
I think we need to make sure this widget works also when it's inside an ExclusiveGroupWidget. See https://github.com/ecmwf-projects/cads-ui-library/blob/main/cypress/component/ExclusiveGroupWidget.cy.tsx for examples.
There was a problem hiding this comment.
There was a problem hiding this comment.
Added at 667e176 .
pelusanchez
changed the title
src/widgets/FreeformInputWidget.tsx
Outdated
| </WidgetHeader> | ||
| <ReservedSpace data-stylizable='widget freeform-input reserved-error-space'> | ||
| {required && value?.length ? ( | ||
| <Error>The field is required.</Error> |
There was a problem hiding this comment.
I think it should be "This field is required"
There was a problem hiding this comment.
Also, it seems that the message does not disappear even if the value is present.
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Please, update the CHANGELOG as well.
|
The initial version of |
|
@valentinogagliardi Done, created v7.0.0 and added to cads-webportal: https://github.com/ecmwf-projects/cads-webportal/pull/148/commits/d52be1d42681b948655ecae9ca7084f8bdd4bdad |
No description provided.