-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode: Support location
in TerminalOptions
#54
Conversation
727976d
to
8f33bf7
Compare
* Add support for TerminalOptions.location * Implement TerminalLocation * Implement TerminalSplitLocationOptions * Implement TerminalEditorLocationOptions * Keep (bottom area aka TerminalLocation.Panel) as default target Fixes eclipse-theia#11506 Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich <[email protected]>
location
in TerminalOptions
location
in TerminalOptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look at the code and have some minor remarks/questions. I will test this beginning of next week.
packages/terminal/src/browser/terminal-frontend-contribution.ts
Outdated
Show resolved
Hide resolved
packages/terminal/src/browser/terminal-frontend-contribution.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Lucas Koehler <[email protected]> Signed-off-by: Olaf Lessenich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes with the provided extension and it worked well for me.
I added one more minor inline suggestion.
Co-authored-by: Lucas Koehler <[email protected]>
What it does
Support
location
in TerminalOptions, whereaslocation
can beTerminalLocation
enum with the valuesEditor
andPanel
TerminalEditorLocationOptions
object which contains aViewColumn
and an optionalpreserveFocus
booleanViewColumn
can beActive
,Besides
, or an explicit column fromOne
toNine
TerminalSplitLocationOptions
object which contains aparentTerminal
that is supposed to be split.Contributed on behalf of STMicroelectronics
Fixes eclipse-theia#11506
How to test
plugins
folder.Open terminal in editor
opens a terminal in the main areaOpen terminal in panel
opens a terminal in the bottom areaOpen terminal with TerminalSplitLocationOptions
splits the provided parent terminal, the test extension uses the most recent one as parent argumentApparently, this one is currently broken in VS Code and just opens a terminal/tab in the panel area without splitting anything
Open terminal with TerminalEditorLocationOptions
provides quick picks for ViewColumn and PreserveFocusApparently this is currently broken in VS Code, it seems to always open a tab in the first column. No idea what is actually supposed to happen - maybe tab in active column if there already is a terminal?
Review checklist
Reminder for reviewers
Footnotes
The VSCode API specification and the current behavior of VSCode seems to be misaligned and at least partly broken in VSCode. ↩