Fix memory leaks #708
Closed
Fix memory leaks #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#566 is expected to land soon. I'd suggest to rebase this PR on #566 and to coordinate with @YuanYuYuan regarding task handling and management. |
- kill tasks through task controller - code clean up - removed valgrind log - added documentation - fix fmt - Runtime::close() now breaks cyclic references in self.router.tables.tables.root_res
DenisBiryukov91
force-pushed
the
fix/memory-leaks-finalizers
branch
from
a6da9e8 to
ae0811e
Compare
Mallets
reviewed
Feb 2, 2024
… cyclic refs in resource
- removed no longer needed Resource::close method
…nation code for hats in runtime.close()
|
@DenisBiryukov91 What's the latest status of this PR? Also, would be great if you can add the timeline to the respective issue |
|
@imstevenpmwork This was kind of finished for the main branch at the moment of last commit, but due to transition async-std->Tokyo, task termination part would likely need to be redone, so it is postponed until #566 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a series of memory leaks detected by valgrind (Fixes #695 ):
Valgrind still reports some leaks, but they seem to be due to async_std (no mention of any Zenoh code, and similar "leaks" are also observed when running a simple hello world-type async example).