-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix z_sub_thr termination and improve perf #1609
fix: fix z_sub_thr termination and improve perf #1609
Conversation
Using `Thread::unpark` `std::process::exit` allows session to be closed, and callback final print to be executed. Callback lock accounted for 2.5% of z_sub_thr perf. Using atomic and fine-grained lock remove the performance impact (even if it doesn't really change the global outcome).
Any change on the example should be aligned with all Zenoh bindings. |
Just to reiterate on the point. Any change in examples needs to be coordinated across all bindings. I'm marking this PR as invalid for the time being till further actions are taken. Either closing the PR or providing updates to all other bindings. |
The throughput examples are not really aligned across bindings. That's why I think that both C and C++ example should be fixed and aligned on this more correct new Rust version. |
Then we need a review of the examples. Again to reiterate on the point, any change in examples needs to be coordinated across all bindings. Modifying this example right now would also bring a difference w.r.t. historical measurements. |
Ok, so it's better to close this PR anyway. |
Using
Thread::unpark
std::process::exit
allows session to be closed, and callback final print to be executed.Callback lock accounted for 2.5% of z_sub_thr perf. Using atomic and fine-grained lock remove the performance impact (even if it doesn't really change the global outcome).