API rework #404
Merged
API rework #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashacmc
force-pushed
the
ctr_api_rework
branch
from
256568c to
755fad0
Compare
sashacmc
force-pushed
the
ctr_api_rework
branch
2 times, most recently
from
b05f180 to
9f6bd76
Compare
cguimaraes
reviewed
May 4, 2024
Not removed, but changed (here is almost finished work for zenoh-c eclipse-zenoh/zenoh-c#346) |
sashacmc
force-pushed
the
ctr_api_rework
branch
3 times, most recently
from
4e8ca75 to
f4d4438
Compare
|
@sashacmc Please change the base branch to dev/1.0.0 as protocol_changes is no longer the development branch. |
Switch query callback replies to rc
Fix some string rework issues
Add value encoding function
* fix: init encoding in put options * fix: switch z_keyexpr functions return value to _Bool * fix: z_api_alignment_test issues * fix: z_api_alignment_test memory leak * fix: missin reply encoding in z_client_test * fix: add value encoding in examples * ci: add retry to raweth test
+ Formatting fix
* feat: add zenoh-c decode bytes function * fix: rename string_from_bytes to string_convert_bytes * feat: add _z_string_from_bytes function
* refactor: reworking encoding prefix enum * feat: create net/encoding module * fix: missing include in logging module * fix: update files with encoding module * feat: rework z_encoding api * fix: remove encoding from freertos examples * feat: add encoding_loan_check function * feat: update tests & examples with new encoding * fix: bad size schema allocation * feat: add _z_encoding clear and check functions * feat: add _z_encoding copy and move functions * fix: use _z_encoding_check for errors * fix: set encoding id value * fix: missing end of file newline * fix: deactivate faulty workflow * doc: improve encoding documentation * fix: missing new encoding functions * fix: pr corrections * fix: update examples * fix: remove z_encoding_loan_check * feat: rework _z_encoding make/wrap functions * fix: update alignment test * fix: missing return statement * fix: create encoding in loop as it's moved * feat: add z_encoding_move function * fix: compilation/test issue * fix: missing z_move to alignment test * fix: remove default encoding struct
* doc: update doc comment for api functions * feat: rework z_sub_keyexpr * doc: update comments * doc: update type doc * fix: revert doc changes
jean-roland
approved these changes
Jun 7, 2024
milyin
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the API according to new Zenoh C API concept.
What should be done to finish the PR:
*_dropis safe @sashacmcRework z_reply_data_t to owned(removed from API) @sashacmcNB: We don't touch attachment and payload parts, it will be reworked after.