Fix - Changed encoding from Base64 (with padding) to Base64URL (no padding) for SenML JSON format #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed the commit message according to the rules. |
Fix - Changed encoding from Base64 (with padding) to Base64URL (no paddi ng) for data value 'vd' over SenML JSON format. According to the SenML JSON specification defined at RFC8428§4.3 the Base64 URL safe alphabet must be used (without padding) for Data Value 'vd': "(*) Data Value is a base64-encoded string with the URL-safe alphabet as defined in Section 5 of [RFC4648], with padding omitted. (In CBOR, the octets in the Data Value are encoded using a definite-length byte string, major type 2.)" So, encoding and decoding has been changed from Base64 (with padding) to Base64Url (without padding) for data value 'vd' over SenML JSON format. Note that the behavior of the code in data/json.c has not changed, data in JSON format will continue to be encoded in Base64 (with padding), see eclipse-leshan/leshan#1444 (comment) New tests has been added in order to test the Base64Url (without padding) encode and decode functions, and the previous tests have been modified by adding a new entry to be tested. Fix: eclipse-wakaama#698 also see: github.com/OpenMobileAlliance/OMA_LwM2M_for_Developers/issues/553
parmi93
force-pushed
the
base64_URL_no_padding
branch
from
af8f2f4
to
013b205
Compare
|
Removed the history of commits, in order to be able to resolve errors related to commit messages that did not respect the rules. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the SenML JSON specification defined at RFC8428§4.3- SenML Labels the Base64 URL safe alphabet must be used (without padding) for Data Value
vd:So, encoding and decoding has been changed from Base64 (with padding) to Base64Url (without padding) for data over SenML JSON format.
Note that the behavior of the code in
data/json.chas not changed, data in JSON format will continue to be encoded in Base64 (with padding), see eclipse/leshan#1444 (comment).New tests has been added in order to test the Base64Url (without padding) encode and decode functions, and the previous tests have been modified by adding a new entry to be tested.
Fix: #698
also see: OpenMobileAlliance/OMA_LwM2M_for_Developers#553