Do not link to docker-compose.yml #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
JKRhb
reviewed
Oct 24, 2024
| @@ -98,7 +98,7 @@ See the mashup's [readme](./mashups/smart-home/README.md). | |||
|
|
|||
| ### Using docker-compose | |||
|
|
|||
| You can start the devices inside a container, for that running `docker-compose up` at the root directory builds and runs the containers. For custom configuration, take a look at the `Dockerfile` of each device or [docker-compose.yml](./docker-compose.yml). | |||
| You can start the devices inside a container, for that running `docker-compose up` at the root directory builds and runs the containers. For custom configuration, take a look at the `Dockerfile` of each device or `docker-compose.yml`. | |||
There was a problem hiding this comment.
Hmm, as you have mentioned in the other PR, there is actually no docker-compose.yml file to be found anywhere in the repository (if I am not mistaken), so maybe this should actually refer to docker-compose-things.yml instead?
Suggested change
| You can start the devices inside a container, for that running `docker-compose up` at the root directory builds and runs the containers. For custom configuration, take a look at the `Dockerfile` of each device or `docker-compose.yml`. | |
| You can start the devices inside a container, for that running `docker-compose up` at the root directory builds and runs the containers. For custom configuration, take a look at the `Dockerfile` of each device or the `docker-compose-things.yml` file in the root directory. |
There was a problem hiding this comment.
|
Sorry I caught up way too late... Basically, this readme needs a bit of updating on how to really use it. That docker-compose-things file shouldn't/cannot be used without the infrastructure repo. Might be even relevant to not even mention it as a guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.