-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preference to ignore files in workspace functions #14449
Conversation
fixed #14448 Signed-off-by: Jonas Helming <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you! The "User Excludes" seem to work very well.
However, in my tests the Git Ignore exclusion doesn't seem to work for the getWorskpaceFileList
function:
A few minors:
- The title "Worskpace-function" stands out a bit, because it is the only pref title that uses a "-". In general, I think the labels are not very nice if they are camel-cased. I created a separate ticket on that (Improve AI settings labels #14452)
- I think we should name the preference about user excludes more from the perspective of the user, e.g. "Excluded File Patterns" is better?
packages/ai-workspace-agent/src/browser/workspace-preferences.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Philip Langer <[email protected]>
Co-authored-by: Philip Langer <[email protected]>
Signed-off-by: Jonas Helming <[email protected]>
@planger I tried to adress all comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the revision! Looks much cleaner now imho!
Please see two more suggestions inline, also regarding the bug I observed. Eitherway, I'm fine with the current state, even though I think my suggestions make sense.
Edit: One more nit... I'd find it better to make the private methods protected, this way, adopters can overwrite them.
Co-authored-by: Philip Langer <[email protected]>
Co-authored-by: Philip Langer <[email protected]>
Downgraded minimatch for Node 18 compatibility Signed-off-by: Jonas Helming <[email protected]>
fixed #14448
What it does
adds two settings to specify fles an directories to be ignored by the workspace functions:
How to test
Ignore files in both settings. Ask the workspace agent "is the a file/folder XYZ in the workspace". Specifically change the .gitignore at runtime to test file watching.
Review checklist
Reminder for reviewers