fix(ai): adjust chat input height dynamically #14432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far the height of the chat input field only was increased with Ctrl+Enter, but not when the lines broke due to their length, or when the view was resized. With this change, we adapt the height of the input also during normal typing when the content wraps into a new line. Moreover, we add a short transition when adjusting the height to make it look smoother.
planger
force-pushed
the
planger/ai/adjust-chat-input-height
branch
from
ada2378
to
ccbfead
Compare
sdirix
approved these changes
Nov 12, 2024
| @@ -126,14 +126,17 @@ const ChatInput: React.FunctionComponent<ChatInputProperties> = (props: ChatInpu | |||
| const lastRequest = allRequests.length === 0 ? undefined : allRequests[allRequests.length - 1]; | |||
|
|
|||
| const createInputElement = async () => { | |||
| const padding = 8; | |||
There was a problem hiding this comment.
Nitpick: For consistency I would call this paddingTop as it's only used for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
So far the height of the chat input field only was increased with Ctrl+Enter, but not when the lines broke due to their length, or when the view was resized.
With this change, we adapt the height of the input also during normal typing when the content wraps into a new line. Moreover, we add a short transition when adjusting the height to make it look smoother.
How to test
output2.webm
Type long text into the AI Chat input and observe how the height is adjusted up to a maximum height. Also resize the chat window until the line wrapping is affected, and type Ctrl+Enter.
Follow-ups
None
Review checklist
Reminder for reviewers