-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vscode] Support specifying the location
in terminal options
#11506
Closed
4 tasks
Tracked by
#11520
Comments
This was referenced Aug 3, 2022
I'll have a look at this. |
xai
added a commit
to eclipsesource/theia
that referenced
this issue
Dec 9, 2022
* Add support for TerminalOptions.location * Add definitions for TerminalLocation, TerminalEditorLocationOptions, and TerminalSplitLocationOptions This is needed for VSCode compatibility * Keep (bottom) as default target Fixes eclipse-theia#11506 Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich <[email protected]>
1 task
xai
added a commit
to eclipsesource/theia
that referenced
this issue
Dec 9, 2022
* Add support for TerminalOptions.location * Add definitions for TerminalLocation, TerminalEditorLocationOptions, and TerminalSplitLocationOptions This is needed for VSCode compatibility * Keep (bottom) as default target Fixes eclipse-theia#11506 Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich <[email protected]>
xai
added a commit
to eclipsesource/theia
that referenced
this issue
Dec 14, 2022
* Add support for TerminalOptions.location * Implement TerminalLocation * Implement TerminalSplitLocationOptions * Implement TerminalEditorLocationOptions * Keep (bottom area aka TerminalLocation.Panel) as default target Fixes eclipse-theia#11506 Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich <[email protected]>
xai
added a commit
to eclipsesource/theia
that referenced
this issue
Dec 14, 2022
* Add support for TerminalOptions.location * Implement TerminalLocation * Implement TerminalSplitLocationOptions * Implement TerminalEditorLocationOptions * Keep (bottom area aka TerminalLocation.Panel) as default target Fixes eclipse-theia#11506 Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich <[email protected]>
xai
added a commit
to eclipsesource/theia
that referenced
this issue
Dec 19, 2022
* Add support for TerminalOptions.location * Implement TerminalLocation * Implement TerminalSplitLocationOptions * Implement TerminalEditorLocationOptions * Keep (bottom area aka TerminalLocation.Panel) as default target Fixes eclipse-theia#11506 Contributed on behalf of STMicroelectronics Co-authored-by: Lucas Koehler <[email protected]> Signed-off-by: Olaf Lessenich <[email protected]>
1 task
xai
added a commit
to eclipsesource/theia
that referenced
this issue
Jan 4, 2023
* Add support for TerminalOptions.location * Implement TerminalLocation * Implement TerminalSplitLocationOptions * Implement TerminalEditorLocationOptions * Keep (bottom area aka TerminalLocation.Panel) as default target Fixes eclipse-theia#11506 Contributed on behalf of STMicroelectronics Co-authored-by: Lucas Koehler <[email protected]> Signed-off-by: Olaf Lessenich <[email protected]>
JonasHelming
pushed a commit
that referenced
this issue
Jan 9, 2023
* vscode: Support location in TerminalOptions * Add support for TerminalOptions.location * Implement TerminalLocation * Implement TerminalSplitLocationOptions * Implement TerminalEditorLocationOptions * Keep (bottom area aka TerminalLocation.Panel) as default target Fixes #11506 Contributed on behalf of ST Microelectronics Signed-off-by: Olaf Lessenich <[email protected]> Co-authored-by: Lucas Koehler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The enum type
TerminalLocation
defines where a terminal shall be located (Panel
orEditor
) and can be specified in the propertylocation
of:TerminalOptions
: missing optional propertylocation
ExtensionTerminalOptions
: missing optional propertylocation
TerminalEditorLocationOptions
: entire type is missingTerminalSplitLocationOptions
: entire type is missingRelated VSCode API issues:
Terminal#creationOptions
#11138iconPath
andcolor
inTerminalOptions
andExtensionTerminalOptions
#11504TerminalProfileProvider
#11503The text was updated successfully, but these errors were encountered: