Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Support specifying the location in terminal options #11506

Closed
4 tasks
Tracked by #11520
planger opened this issue Aug 3, 2022 · 1 comment · Fixed by #12006
Closed
4 tasks
Tracked by #11520

[vscode] Support specifying the location in terminal options #11506

planger opened this issue Aug 3, 2022 · 1 comment · Fixed by #12006
Assignees
Labels
terminal issues related to the terminal vscode issues related to VSCode compatibility

Comments

@planger
Copy link
Contributor

planger commented Aug 3, 2022

The enum type TerminalLocation defines where a terminal shall be located (Panel or Editor) and can be specified in the property location of:

Related VSCode API issues:

@xai
Copy link
Contributor

xai commented Oct 3, 2022

I'll have a look at this.

@msujew msujew added the terminal issues related to the terminal label Dec 8, 2022
xai added a commit to eclipsesource/theia that referenced this issue Dec 9, 2022
* Add support for TerminalOptions.location
* Add definitions for TerminalLocation, TerminalEditorLocationOptions, and TerminalSplitLocationOptions
  This is needed for VSCode compatibility
* Keep (bottom) as default target

Fixes eclipse-theia#11506

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <[email protected]>
xai added a commit to eclipsesource/theia that referenced this issue Dec 9, 2022
* Add support for TerminalOptions.location
* Add definitions for TerminalLocation, TerminalEditorLocationOptions, and TerminalSplitLocationOptions
  This is needed for VSCode compatibility
* Keep (bottom) as default target

Fixes eclipse-theia#11506

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <[email protected]>
xai added a commit to eclipsesource/theia that referenced this issue Dec 14, 2022
* Add support for TerminalOptions.location
* Implement TerminalLocation
* Implement TerminalSplitLocationOptions
* Implement TerminalEditorLocationOptions
* Keep (bottom area aka TerminalLocation.Panel) as default target

Fixes eclipse-theia#11506

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <[email protected]>
xai added a commit to eclipsesource/theia that referenced this issue Dec 14, 2022
* Add support for TerminalOptions.location
* Implement TerminalLocation
* Implement TerminalSplitLocationOptions
* Implement TerminalEditorLocationOptions
* Keep (bottom area aka TerminalLocation.Panel) as default target

Fixes eclipse-theia#11506

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <[email protected]>
xai added a commit to eclipsesource/theia that referenced this issue Dec 19, 2022
* Add support for TerminalOptions.location
* Implement TerminalLocation
* Implement TerminalSplitLocationOptions
* Implement TerminalEditorLocationOptions
* Keep (bottom area aka TerminalLocation.Panel) as default target

Fixes eclipse-theia#11506

Contributed on behalf of STMicroelectronics

Co-authored-by: Lucas Koehler <[email protected]>
Signed-off-by: Olaf Lessenich <[email protected]>
xai added a commit to eclipsesource/theia that referenced this issue Jan 4, 2023
* Add support for TerminalOptions.location
* Implement TerminalLocation
* Implement TerminalSplitLocationOptions
* Implement TerminalEditorLocationOptions
* Keep (bottom area aka TerminalLocation.Panel) as default target

Fixes eclipse-theia#11506

Contributed on behalf of STMicroelectronics

Co-authored-by: Lucas Koehler <[email protected]>
Signed-off-by: Olaf Lessenich <[email protected]>
JonasHelming pushed a commit that referenced this issue Jan 9, 2023
* vscode: Support location in TerminalOptions

* Add support for TerminalOptions.location
* Implement TerminalLocation
* Implement TerminalSplitLocationOptions
* Implement TerminalEditorLocationOptions
* Keep (bottom area aka TerminalLocation.Panel) as default target

Fixes #11506

Contributed on behalf of ST Microelectronics

Signed-off-by: Olaf Lessenich <[email protected]>

Co-authored-by: Lucas Koehler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terminal issues related to the terminal vscode issues related to VSCode compatibility
Projects
None yet
4 participants